Re: Collation & ctype method table, and extension hooks - Mailing list pgsql-hackers

On Wed, Jun 11, 2025 at 10:49:17PM -0700, Jeff Davis wrote:
> Attached v16.

> I plan to commit this soon after branching.

> Subject: [PATCH v16 1/4] Control ctype behavior internally with a method
>  table.
> 
> Previously, pattern matching and case mapping behavior branched based
> on the provider.
> 
> Refactor to use a method table, which is less error-prone and easier
> to hook.

This became refactor commit 5a38104.  In a UTF8 database, the commit changed
the behavior of:

  SELECT 'café' ILIKE 'caf_' COLLATE "C";

That query reports true in v18, false in v19.  I've copied Claude's whole
review for the commit to
https://docs.google.com/document/d/19_xKpKUQlY5N51qbfXyipXs3rqIYEC3qk5oaUDJ48YA/edit?tab=t.0.
Two of its other findings sound potentially important, but I didn't verify
them.

nm