Re: [PATCH] Fix missing-field-initializers and sign comparison warnings - Mailing list pgsql-hackers

From Zakariyah Ali
Subject Re: [PATCH] Fix missing-field-initializers and sign comparison warnings
Date
Msg-id 20260619132644.111725-1-zakariyahali100@gmail.com
Whole thread
In response to [PATCH] Fix compiler warnings by using designated initializers  (Zakariyah Ali <zakariyahali100@gmail.com>)
List pgsql-hackers
Hi Tom, Peter,

The warnings for the `ErrorSaveContext` and the `pg_dependencies_out()` loop counter were observed with GCC using the
`-Wmissing-field-initializers`and `-Wsign-compare` flags. 
 

However, I completely understand the concern that these warnings are not part of PostgreSQL's currently supported
warningset. I agree that making code changes (like switching to designated initializers or changing loop types) just to
satisfythese non-default flags isn't the right approach without a project-wide consensus to enforce them.
 

Given that, I will drop this patch. Thank you both for your time, the reviews, and the insights into how the project
handlescompiler warnings!
 

Best regards,
Zakariyah



pgsql-hackers by date:

Previous
From: Nikhil Shetty
Date:
Subject: Re: Proposal: Conflict log history table for Logical Replication
Next
From: Bertrand Drouvot
Date:
Subject: Re: Avoid orphaned objects dependencies, take 3