Re: [PATCH] Fix minRecoveryPoint not advanced past checkpoint in CreateRestartPoint - Mailing list pgsql-hackers

From Kyotaro Horiguchi
Subject Re: [PATCH] Fix minRecoveryPoint not advanced past checkpoint in CreateRestartPoint
Date
Msg-id 20260610.135335.1492475965692488167.horikyota.ntt@gmail.com
Whole thread
In response to Re: [PATCH] Fix minRecoveryPoint not advanced past checkpoint in CreateRestartPoint  (Nitin Jadhav <nitinjadhavpostgres@gmail.com>)
Responses Re: [PATCH] Fix minRecoveryPoint not advanced past checkpoint in CreateRestartPoint
List pgsql-hackers
I tend to agree with Michael on the meaning of minRecoveryPoint.

If a tool is using minRecoveryPoint to determine how far recovery has
progressed, then I would say it is looking at the wrong value. I also
do not quite understand what such a tool is trying to verify by
comparing minRecoveryPoint with the recovery target LSN.

If the goal is to verify that recovery reached the configured target,
PostgreSQL already performs that check itself and exits with a FATAL
error otherwise:

>  ereport(FATAL,
>     (errcode(ERRCODE_CONFIG_FILE_ERROR),
>      errmsg("recovery ended before configured recovery target was reached")));

If the underlying use case were explained in more detail, we could
probably have a more concrete discussion about how to address
it. However, I do not think changing the semantics of minRecoveryPoint
is the right solution based on the information available so far.

Regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center



pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: Support EXCEPT for TABLES IN SCHEMA publications
Next
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: Reject negative max_retention_duration values