Re: Add wait events for server logging destination writes - Mailing list pgsql-hackers

From Kyotaro Horiguchi
Subject Re: Add wait events for server logging destination writes
Date
Msg-id 20260601.144922.658666928129832364.horikyota.ntt@gmail.com
Whole thread
In response to Add wait events for server logging destination writes  (신성준 <shinsj4653@gmail.com>)
List pgsql-hackers
Hello.

At Sun, 31 May 2026 17:50:08 +0900, 신성준 <shinsj4653@gmail.com> wrote in 
> Attached is a short series that adds two WaitEventIO events and reports
> them around those writes:
> 
>   IO / SysloggerWrite - write(2) to the syslogger pipe
>   IO / StderrWrite - write(2) to stderr, and WriteConsoleW()
> 
> 0001 adds the events and covers the write(2) paths. 0002 does the
> Windows WriteConsoleW() path, split out since it's platform-specific.

Should we also consider instrumenting ReportEventW()/ReportEventA()?
They seem to be another Windows-specific logging output path.

Also, if the intention is to cover all places where logging output can
block, I wonder whether the syslog() calls should be covered as
well. If they are intentionally excluded, perhaps a short comment
explaining the rationale would be useful.

Regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Add pg_stat_kind_info system view
Next
From: Michael Paquier
Date:
Subject: Re: pg_stat_statements: Fix normalization of + signs for FETCH and MOVE