Re: Adding REPACK [concurrently] - Mailing list pgsql-hackers

Hello,

On 2026-Mar-20, Mihail Nikalayeu wrote:

> Hello, everyone!
> 
> Some comments for v43:

Many thanks for the review.  I have applied fixes for these, so here's
v44.  Changes:

- 0001 now simply renames the existing function and adds the
"concurrently" flag, instead of adding a separate function.  I don't
think there's a reason to keep the previous function name.

- 0002 is unchanged.

- 0003 contains the fixes to the problems pointed out by Mihail;
  otherwise it's pretty much the same as in v43.

- 0004 is Antonin's bugfix from the crash reported by Srinath.

- 0005 to 0007 are my proposed changes on this round.  It's mostly just
  cosmetics.  I intend to squash these all into a single commit (0003 to
  at least 0007) when posting the next version.

- 0008 to 0010 are as posted by Antonin; they are unchanged, except for
  fixes for the problems pointed out by Mihail.  Antonin, I would
  appreciate it if you want to change the "reform" bit in 0007 as
  discussed.

For the next version I'll probably also rename the file cluster.c to
repack.c as well as assorted symbols therein, as well as studying the
coverage more closely.

Thanks,

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/