Re: Fix array access (src/bin/pg_dump/pg_dump.c) - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Fix array access (src/bin/pg_dump/pg_dump.c)
Date
Msg-id 202603071332.763hisfhn45h@alvherre.pgsql
Whole thread Raw
In response to Re: Fix array access (src/bin/pg_dump/pg_dump.c)  (Ranier Vilela <ranier.vf@gmail.com>)
List pgsql-hackers
On 2024-Nov-12, Ranier Vilela wrote:

> Em ter., 12 de nov. de 2024 às 16:11, Alvaro Herrera <
> alvherre@alvh.no-ip.org> escreveu:
> 
> > On 2024-Nov-12, Ranier Vilela wrote:
> >
> > > Per Coverity.
> > >
> > > The function *determineNotNullFlags* has a little oversight.
> > > The struct field *notnull_islocal* is an array.
> > >
> > > I think this is a simple typo.
> > > Fix using array notation access.
> >
> > Yeah, thanks, I had been made aware of this bug.  Before fixing I'd like
> > to construct a test case that tickles that code, because it's currently
> > uncovered  *shudder*
>
> Thanks for taking care of this.

Fixed, thanks.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/



pgsql-hackers by date:

Previous
From: Álvaro Herrera
Date:
Subject: Re: [BUG?] missing array index may result in a wrong constraint name (pg_dump, bin-upgrade, >=18)
Next
From: Evgeny Voropaev
Date:
Subject: Compress prune/freeze records with Delta Frame of Reference algorithm