Re: [PATCH] Add Windows support for backtrace_functions (MSVC only) - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: [PATCH] Add Windows support for backtrace_functions (MSVC only)
Date
Msg-id 202602241705.pd2wr4oku4nh@alvherre.pgsql
Whole thread Raw
In response to Re: [PATCH] Add Windows support for backtrace_functions (MSVC only)  (Bryan Green <dbryan.green@gmail.com>)
Responses Re: [PATCH] Add Windows support for backtrace_functions (MSVC only)
List pgsql-hackers
On 2026-Feb-23, Bryan Green wrote:

> I have removed all but the SymCleanup form the backtrace_cleanup since
> it happens at process exit.  I have implemented not retrying as you
> described above.
> 
> Let me know if this was what you were thinking.

OK, thanks, that's pretty much what I was thinking.  I've pushed this
now.  One last change I did is add a check that the wchar2char() return
value isn't the full size of the output buffer, because IIUC that's the
way it's intended to be used, and it matches the one existing caller
that doesn't rely on the max_encoding_chars thing.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"Entristecido, Wutra                     (canción de Las Barreras)
echa a Freyr a rodar
y a nosotros al mar"



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: Proposal: ANALYZE (MODIFIED_STATS) using autoanalyze thresholds
Next
From: Bertrand Drouvot
Date:
Subject: Make use of unvolatize() in vac_truncate_clog()