Re: pg_ctl start may return 0 even if the postmaster has been already started on Windows - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: pg_ctl start may return 0 even if the postmaster has been already started on Windows
Date
Msg-id 202602021323.y4ctu6t5biso@alvherre.pgsql
Whole thread Raw
In response to Re: pg_ctl start may return 0 even if the postmaster has been already started on Windows  (Bryan Green <dbryan.green@gmail.com>)
List pgsql-hackers
Hello,

Somebody seems to have trimmed the CC field upthread for no apparent
reason.  I put it back the way I think it was when that happened.

Here's a rebased version of this patch.  This is pretty much just
Bryan's patch, which I agree is a good way forward, though perhaps not
very backpatchable.  I suspect we need to consider this one for mastern
only, and use a less intrusive version for backpatching -- perhaps
Kyotaro's earlier version.

Regarding this patch, I haven't really reviewed it -- but I wonder why
we need two global variables to keep postmaster's PID: the newly
introduced pm_pid (which was previously a local variable only) and the
preexisting postmasterPID.  I suspect this needs to be cleaned up.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Los minutos y los segundos son mercadería de la ciudad, donde un infeliz se
afana por no perder ni siquiera un segundo y no advierto que obrando de ese
modo pierde una vida."              ("La vuelta de Don Camilo", G. Guareschi)

Attachment

pgsql-hackers by date:

Previous
From: Tatsuya Kawata
Date:
Subject: Re: [PATCH] ANALYZE: hash-accelerate MCV tracking for equality-only types
Next
From: Aditya Kamath
Date:
Subject: RE: AIX support