On 2026-Jan-29, Peter Eisentraut wrote:
> You could spruce this up further like
>
> [LockTupleKeyShare] = {
> .hwlock = AccessShareLock,
> ...
> },
Oh right, done that way.
> The comments "/* KeyShare does not allow updating tuples */" etc. seem
> repetitive and don't actually explain why -1 is an appropriate value. You
> could instead write a comment by the declaration of the updstatus field,
> like "set to -1 if the tuple lock mode does not allow updating tuples (see
> get_mxact_status_for_lock())".
Good point. I rewrote the comment on top of the declaration and pushed,
thanks for the reviews.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Hay dos momentos en la vida de un hombre en los que no debería
especular: cuando puede permitírselo y cuando no puede" (Mark Twain)
