Re: Issues with ON CONFLICT UPDATE and REINDEX CONCURRENTLY - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: Issues with ON CONFLICT UPDATE and REINDEX CONCURRENTLY
Date
Msg-id 202601281425.dqtjx6i2kow2@alvherre.pgsql
Whole thread Raw
In response to Re: Issues with ON CONFLICT UPDATE and REINDEX CONCURRENTLY  (Mihail Nikalayeu <mihailnikalayeu@gmail.com>)
List pgsql-hackers
Hello,

On 2026-Jan-28, Mihail Nikalayeu wrote:

> And about the opposite race + assert (not sure we need to keep it).

I pushed the fix, removing the assert and comment about the whole
scenario.  I'm not sure the assert was doing much, because as I recall,
the index array is populated using the index list obtained from
relcache, which is sorted numerically by OID by definition, so the
assert is pretty much tautological.

I'm unconvinced that there aren't problems in this code related to OID
wraparound for indexes, but I couldn't find any after some testing.
That of course doesn't prove anything.

Many thanks for your efforts here.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"La libertad es como el dinero; el que no la sabe emplear la pierde" (Alvarez)



pgsql-hackers by date:

Previous
From: "Euler Taveira"
Date:
Subject: Re: [PATCH] Add max_logical_replication_slots GUC
Next
From: torikoshia
Date:
Subject: Re: RFC: Allow EXPLAIN to Output Page Fault Information