Re: Cleanup shadows variable warnings, round 1 - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: Cleanup shadows variable warnings, round 1
Date
Msg-id 202512041120.t3l7vzgdlzhj@alvherre.pgsql
Whole thread Raw
In response to Re: Cleanup shadows variable warnings, round 1  (Chao Li <li.evan.chao@gmail.com>)
Responses Re: Cleanup shadows variable warnings, round 1
List pgsql-hackers
On 2025-Dec-04, Chao Li wrote:

> The motivation is that CF’s CI currently fails on shadow-variable warnings.
> If you touch a file like a.c, and that file already has a legacy shadowing
> issue, CI will still fail your patch even if your changes are correct. Then
> you’re forced to fix unrelated shadow-variable problems just to get a clean
> CI run. I’ve run into this myself, and it’s disruptive for both patch
> authors and reviewers.

Hmm, maybe that should be turned off.  It sounds seriously unhelpful.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"En las profundidades de nuestro inconsciente hay una obsesiva necesidad
de un universo lógico y coherente. Pero el universo real se halla siempre
un paso más allá de la lógica" (Irulan)



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: headerscheck ccache support
Next
From: Shlok Kyal
Date:
Subject: Re: Skipping schema changes in publication