Re: Issues with ON CONFLICT UPDATE and REINDEX CONCURRENTLY - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: Issues with ON CONFLICT UPDATE and REINDEX CONCURRENTLY
Date
Msg-id 202511251737.kuptxwylgmtx@alvherre.pgsql
Whole thread Raw
In response to Re: Issues with ON CONFLICT UPDATE and REINDEX CONCURRENTLY  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On 2025-Nov-24, Mihail Nikalayeu wrote:

> In a few words - it is an attempt to make sure the test goes to the
> wake-up backend only after it actually enters to wait mode. For that
> reason an additional 'notice' point is used by spec.
> I have proposed another possible solution for the [0] thread.

That makes sense.  I pushed it now, many thanks.


On 2025-Nov-25, Michael Paquier wrote:

> Reading through bc32a12e0db2, I am puzzled by the committed result
> here:
> +#ifdef USE_INJECTION_POINTS
> +   if (conflict)
> +       INJECTION_POINT("check-exclusion-or-unique-constraint-conflict", NULL);
> +   else
> +       INJECTION_POINT("check-exclusion-or-unique-constraint-no-conflict", NULL);
> +#endif

> If you have no plans for it in the long-term, I'd rather remove it
> from the tree, rather than keep it.

Removed.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"We have labored long to build a heaven, only to find it
populated with horrors"                        (Prof. Milton Glass)



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: pgsql: Teach DSM registry to ERROR if attaching to an uninitialized ent
Next
From: Álvaro Herrera
Date:
Subject: Re: The pgperltidy diffs in HEAD