Re: Few untranslated error messages in OAuth - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: Few untranslated error messages in OAuth
Date
Msg-id 202511130803.y5k3yypn5323@alvherre.pgsql
Whole thread Raw
In response to Few untranslated error messages in OAuth  ("Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>)
Responses Re: Few untranslated error messages in OAuth
List pgsql-hackers
On 2025-Nov-13, Zhijie Hou (Fujitsu) wrote:

> Hi,
> 
> During testing of libpq, I noticed several error messages not processed by
> libpq_gettext, resulting in their exclusion from *.pot files. The attached patch
> wraps these messages.

Yeah, this roughly makes sense.  I think the documentation for errctx in
async_ctx needs to be updated though, because currently it says "it'll
be translated for you" but this patch makes it the other way around (it
must come translated).

Alternatively, we could mark the strings with gettext_noop(), which only
adds the messages to the catalog without translating them; so the
responsibility of translating them would remain where it is today.  This
might be easier.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"No tengo por qué estar de acuerdo con lo que pienso"
                             (Carlos Caszeli)



pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: Suggestion to add --continue-client-on-abort option to pgbench
Next
From: Álvaro Herrera
Date:
Subject: Re: [PATCH] Add pg_get_subscription_ddl() function