Re: [PATCH] Add pg_get_subscription_ddl() function - Mailing list pgsql-hackers

On 2025-Nov-11, Vaibhav Dalvi wrote:

> Hi Alvaro,
> 
> Thanks for the explanation.
> 
> I tried to get rid of String usage in 0001 patch.
> Prepared 0002 patch for actual implementation of the
> function p_get_subscription_ddl().

OK, now I understand what you meant when you mentioned
CreateSubscriptionStmt: the problem is that the same code is being used
for the purposes of processing the subscription lists of both
Subscription and SubscriptionStmt.  I think this whole code is a bit
ugly TBH -- not yours, but what was there before -- but now that I've
realized this, I think stripping those values out of the String wrapping
is the wrong direction to go in, because it leads to more contortions
rather than less.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"They proved that being American is not just for some people"
                                               (George Takei)