Request a Demo
Home   >   mailing lists

Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement
Date
Msg-id 202511051258.3j3ljaokhlqm@alvherre.pgsql
Whole thread Raw
In response to Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement  (Nishant Sharma <nishant.sharma@enterprisedb.com>)
List pgsql-hackers
Tree view 
On 2025-Nov-05, Nishant Sharma wrote:

> Thanks Álvaro for the review comments on v4!
> 
> PFA, v5 patch set. I have included all your review comments.

Great, thanks.

I think adding the get_tablespace_location_string function in
ruleutils.c makes little sense -- I would say it belongs in
src/backend/catalog/pg_tablespace.c.  Since this file happens not to
exist, you can create it.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"Someone said that it is at least an order of magnitude more work to do
production software than a prototype. I think he is wrong by at least
an order of magnitude."                              (Brian Kernighan)

pgsql-hackers by date:

Previous
From: Arseniy Mukhin
Date:
Subject: Re: LISTEN/NOTIFY bug: VACUUM sets frozenxid past a xid in async queue
Next
From: Xuneng Zhou
Date:
Subject: Re: Add tab completion support for WAIT FOR command