Re: Remove an unnecessary blank line on the PQisBusy() comments - Mailing list pgsql-hackers

From Yugo Nagata
Subject Re: Remove an unnecessary blank line on the PQisBusy() comments
Date
Msg-id 20251024103551.f510319ee96216a738d9154c@sraoss.co.jp
Whole thread Raw
In response to Re: Remove an unnecessary blank line on the PQisBusy() comments  ("Euler Taveira" <euler@eulerto.com>)
List pgsql-hackers
On Thu, 23 Oct 2025 12:19:03 -0300
"Euler Taveira" <euler@eulerto.com> wrote:

> On Thu, Oct 23, 2025, at 12:11 PM, Nathan Bossart wrote:
> > On Thu, Oct 23, 2025 at 08:02:03PM +0900, Yugo Nagata wrote:
> >> I’ve attached a very trivial patch that removes an unnecessary line
> >> after the comments on PQisBusy(), just for consistency with the
> >> surrounding code.
> >
> > Given this line has been there for 28 years (commit edbd513) and isn't
> > hurting anything, I don't see a strong need to change it.
> >
> 
> In this same file there are other cases of blank line after comment and before
> function definition. If, in the future, we have an automated tool (pgindent?)
> that removes such blank line(s) after comment and before function definition, I
> would say fix it. That's not the case; I would leave it alone.

Thank you for taking a look at it.
I was just wondering about it, and agree that there's no need to remove it at
this point since it’s harmless.

Regards,
Yugo Nagata

-- 
Yugo Nagata <nagata@sraoss.co.jp>



pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: Skipping schema changes in publication
Next
From: Quan Zongliang
Date:
Subject: Re: Include extension path on pg_available_extensions