Re: Proposal: Adding compression of temporary files - Mailing list pgsql-hackers

Hello,

This latest patchset is failing CI because of some compiler warnings on
Windows, see below.  Also, who is squashing all these fixup patches?  I
suppose it's up to Filip to submit a squashed version with the ones he
approves of, but he hasn't replied since you (Tomas) posted them; I hope
the series is not dead?

Thanks

[14:52:10.761] buffile.c: In function ‘BufFileLoadBuffer’:
[14:52:10.761] buffile.c:725:95: error: passing argument 2 of ‘uncompress’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
[14:52:10.761]   725 |                                                 ret = uncompress((uint8 *) file->buffer.data,
&len,
[14:52:10.761]       |
^~~~
[14:52:10.761]       |                                                                                               |
[14:52:10.761]       |
size_t* {aka long long unsigned int *}
 
[14:52:10.761] In file included from /usr/x86_64-w64-mingw32/include/zlib.h:34,
[14:52:10.761]                  from buffile.c:64:
[14:52:10.761] /usr/x86_64-w64-mingw32/include/zlib.h:1267:32: note: expected ‘uLongf *’ {aka ‘long unsigned int *’}
butargument is of type ‘size_t *’ {aka ‘long long unsigned int *’}
 
[14:52:10.761]  1267 | ZEXTERN int ZEXPORT uncompress OF((Bytef *dest,   uLongf *destLen,
[14:52:10.761]       |                                ^~
[14:52:10.761] buffile.c: In function ‘BufFileDumpBuffer’:
[14:52:10.761] buffile.c:854:101: error: passing argument 2 of ‘compress2’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
[14:52:10.761]   854 |                                         ret = compress2((uint8 *) (cData +
sizeof(CompressHeader)),&len,
 
[14:52:10.761]       |
  ^~~~
 
[14:52:10.761]       |
  |
 
[14:52:10.761]       |
  size_t * {aka long long unsigned int *}
 
[14:52:10.761] /usr/x86_64-w64-mingw32/include/zlib.h:1244:31: note: expected ‘uLongf *’ {aka ‘long unsigned int *’}
butargument is of type ‘size_t *’ {aka ‘long long unsigned int *’}
 
[14:52:10.761]  1244 | ZEXTERN int ZEXPORT compress2 OF((Bytef *dest,   uLongf *destLen,
[14:52:10.761]       |                               ^~


-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"XML!" Exclaimed C++.  "What are you doing here? You're not a programming
language."
"Tell that to the people who use me," said XML.
https://burningbird.net/the-parable-of-the-languages/