Re: ci: Skip minfree file in the cores_backtrace.sh - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: ci: Skip minfree file in the cores_backtrace.sh
Date
Msg-id 202510171220.2i45gsy3w7af@alvherre.pgsql
Whole thread Raw
In response to ci: Skip minfree file in the cores_backtrace.sh  (Nazir Bilal Yavuz <byavuz81@gmail.com>)
Responses Re: ci: Skip minfree file in the cores_backtrace.sh
List pgsql-hackers
On 2025-Oct-17, Nazir Bilal Yavuz wrote:

>  first=1
> -for corefile in $(find "$directory" -type f) ; do
> +# minfree is not a core file but may exists in the crash directory, skip it
> +for corefile in $(find "$directory" -type f -not -name "minfree") ; do
>      if [ "$first" -eq 1 ]; then
>          first=0
>      else

This looks quite random.  Why not do "find ... -name '*core*'" instead?
I mean, if we have minfree there today, we could have maxbusy tomorrow
or whatever.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"We’ve narrowed the problem down to the customer’s pants being in a situation
 of vigorous combustion" (Robert Haas, Postgres expert extraordinaire)



pgsql-hackers by date:

Previous
From: Álvaro Herrera
Date:
Subject: Re: misleading error message in ProcessUtilitySlow T_CreateStatsStmt
Next
From: Álvaro Herrera
Date:
Subject: Re: Inconsistent LSN format in pg_waldump output