> The individual runs have quite a bit of variation.
It's a known behavior of pgbench.
> It's good to cross check results against known facts. If my napkin
> math is right, a ~1% speedup for ~60ktps/s amounts to saving ~160ns
> per query. It's not plausible that forcing the compiler's hand for
> this branch would save several hundred clock cycles.
>
> To be fair I tried to reproduce and found only noise-level differences:
> master: 61553
> case 1: 61423
> case 2: 61647
That's 0.3% difference, definitely noise-level. Ok, I withdraw my
claim and commit the patch without unlikely().
Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
