Re: Remove unneeded cast in heap_xlog_lock. - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: Remove unneeded cast in heap_xlog_lock.
Date
Msg-id 202508220959.34b6a4whnzwf@alvherre.pgsql
Whole thread Raw
In response to Re: Remove unneeded cast in heap_xlog_lock.  (Kirill Reshke <reshkekirill@gmail.com>)
Responses Re: Remove unneeded cast in heap_xlog_lock.
Re: Remove unneeded cast in heap_xlog_lock.
List pgsql-hackers
On 2025-Aug-22, Kirill Reshke wrote:

> I am uncertain about the delineation between when we make changes and
> when we refrain from doing so.

I think this is natural work after 9c727360bcc7, before which
BufferGetPage() was a macro and strangely enough had its own cast
embedded.  As I understand, the less casts we have, the better.  There's
some other standardization work going on to remove unnecessary casts
elsewhere, so I'm not sure why we wouldn't do this.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"El que vive para el futuro es un iluso, y el que vive para el pasado,
un imbécil" (Luis Adler, "Los tripulantes de la noche")



pgsql-hackers by date:

Previous
From: "Zhijie Hou (Fujitsu)"
Date:
Subject: RE: Add support for specifying tables in pg_createsubscriber.
Next
From: Kirill Reshke
Date:
Subject: Re: misleading error message in ProcessUtilitySlow T_CreateStatsStmt