Request a Demo
Home   >   mailing lists

Re: don't include tableam.h in nbtree.h - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: don't include tableam.h in nbtree.h
Date
Msg-id 202508141552.kosq2bvhduu2@alvherre.pgsql
Whole thread Raw
In response to Re: don't include tableam.h in nbtree.h  (Bertrand Drouvot <bertranddrouvot.pg@gmail.com>)
List pgsql-hackers
Tree view 
On 2025-Aug-05, Bertrand Drouvot wrote:

> I think that makes sense.

Thanks for looking!

> index 1127597bb60..8282055ebca 100644
> --- a/contrib/btree_gist/btree_bool.c
> +++ b/contrib/btree_gist/btree_bool.c
> @@ -6,6 +6,7 @@
>  #include "btree_gist.h"
>  #include "btree_utils_num.h"
>  #include "utils/sortsupport.h"
> +#include "utils/rel.h"
> 
> There is several places like this one where the new include is not ordered based
> on the ASCII values (while it looks like it should be according to 7e735035f2).

Oh yeah, that's been the intention for many years.  This was just me
failing to sort properly ...  thanks for the patch, I included it and
pushed.

Cheers,

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: [PATCH] bms_prev_member() can read beyond the end of the array of allocated words
Next
From: Tom Lane
Date:
Subject: Re: [PATCH] bms_prev_member() can read beyond the end of the array of allocated words