Re: fix ancient typo in transformRelOptions() - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: fix ancient typo in transformRelOptions()
Date
Msg-id 202508052214.sjldy4pl2uvk@alvherre.pgsql
Whole thread Raw
In response to Re: fix ancient typo in transformRelOptions()  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 2025-Aug-05, Tom Lane wrote:

> =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de> writes:
> > On 2025-Aug-05, Nathan Bossart wrote:
> >> I noticed that this function has a "namspace" parameter.  The attached
> >> patch adds the missing 'e'.
> 
> > I have vague recollections of it being this way because of "namespace"
> > being a C++ keyword.  (commit is 3a5b77371522, but I don't have energy
> > to look for the discussion right now.)
> 
> Oh, duh -- if you try cpluspluscheck you'll find it's unhappy.
> I didn't locate the discussion of "namspace" either, but I did
> notice that de160e2c0 used "nameSpace" for the same purpose.
> Maybe we should standardize on that?  It looks less like a typo
> than "namspace", for sure.

WFM.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"No deja de ser humillante para una persona de ingenio saber
que no hay tonto que no le pueda enseñar algo." (Jean B. Say)



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: fix ancient typo in transformRelOptions()
Next
From: Masahiko Sawada
Date:
Subject: Re: Convert varatt.h macros to static inline functions