Re: Get rid of WALBufMappingLock - Mailing list pgsql-hackers

From Noah Misch
Subject Re: Get rid of WALBufMappingLock
Date
Msg-id 20250705041559.45.nmisch@google.com
Whole thread Raw
In response to Re: Get rid of WALBufMappingLock  (Alexander Korotkov <aekorotkov@gmail.com>)
List pgsql-hackers
On Mon, Mar 31, 2025 at 09:18:30PM +0300, Alexander Korotkov wrote:
> I'm going to push the first patch ("nowalbuf") if no objections.

I completed a post-commit review of this patch.  I think the patch is correct.
 
I found some of the variable names and comments challenging, so I made the
attached local edits in the course of the review.  I don't know whether my
choices are better or just tailored to my biases.  If someone thinks this
would improve the tree, I can polish this and commit it.  Absent that,
consider these notes to myself and to other post-commit reviewers.

Attachment

pgsql-hackers by date:

Previous
From: jian he
Date:
Subject: Re: array_random
Next
From: Dilip Kumar
Date:
Subject: Re: [PATCH] Allow parallelism for plpgsql return expression after commit 556f7b7