Re: Foreign key validation failure in 18beta1 - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Foreign key validation failure in 18beta1
Date
Msg-id 202506051701.wjgu2jhnksb5@alvherre.pgsql
Whole thread Raw
In response to Re: Foreign key validation failure in 18beta1  (jian he <jian.universality@gmail.com>)
Responses Re: Foreign key validation failure in 18beta1
List pgsql-hackers
On 2025-Jun-04, jian he wrote:

> On Tue, Jun 3, 2025 at 12:14 PM Amul Sul <sulamul@gmail.com> wrote:
>
> > I found a third approach that requires only a few changes. The key
> > idea is to determine the root referenced table and pass it to
> > QueueFKConstraintValidation(). We would then enqueue phase 3
> > validation only if the constraint tuple’s confrelid matches that root
> > table -- similar to what is doing in ATExecAlterConstrEnforceability().
> >
> > This would also ensure that the logic for adding/skipping phase 3
> > validation is consistent in both places.
>
> indeed!
> 
> v7 is way more intuitive compared with v5, v6.

Agreed, this version is better than the previous ones.  I split it as
two commits, for NOT VALID and NOT ENFORCED separately, and modified some
comments a bit as well as the commit messages.

Thank you!

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"Cuando mañana llegue pelearemos segun lo que mañana exija" (Mowgli)



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: postmaster uses more CPU in 18 beta1 with io_method=io_uring
Next
From: Álvaro Herrera
Date:
Subject: Re: ABI Compliance Checker GSoC Project