Re: Remove unnecessary "lmgr.h" in stat_utils.c - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: Remove unnecessary "lmgr.h" in stat_utils.c
Date
Msg-id 202505080953.6xfgthitc7oq@alvherre.pgsql
Whole thread Raw
In response to Re: Remove unnecessary "lmgr.h" in stat_utils.c  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On 2025-May-08, Michael Paquier wrote:

> Seems worth doing to simplify the code in the long-run, even if these
> require a case-by-case manual lookup.

Yeah, I don't think we can take a patch that simply removes everything
that this report mentions, because some of the includes (especially the
system includes) could be platform-dependent.  Also I imagine some of
them depend on compile-time environment -- e.g., I'm pretty sure
src/port/pg_popcount_aarch64.c is not going to work well without
pg_bitutils.h.

> All that is potential work for v19, of course.

Yep.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Update: super-fast reaction on the Postgres bugs mailing list. The report
was acknowledged [...], and a fix is under discussion.
The wonders of open-source !"
             https://twitter.com/gunnarmorling/status/1596080409259003906



pgsql-hackers by date:

Previous
From: jian he
Date:
Subject: Re: PG 18 release notes draft committed
Next
From: Richard Guo
Date:
Subject: Re: PG 18 release notes draft committed