Re: simplifying grammar for ALTER CONSTRAINT .. SET [NO] INHERIT - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: simplifying grammar for ALTER CONSTRAINT .. SET [NO] INHERIT
Date
Msg-id 202503270827.g6ofbwsgjlcw@alvherre.pgsql
Whole thread Raw
In response to Re: simplifying grammar for ALTER CONSTRAINT .. SET [NO] INHERIT  (Suraj Kharage <suraj.kharage@enterprisedb.com>)
List pgsql-hackers
On 2025-Mar-26, Suraj Kharage wrote:

>  Yes, I agree. As Peter said, it is now inline with other commands.
> 
> I have reviewed the patch and it looks good to me.

Thanks for reviewing!

> Since we are removing the SET keyword, how about removing that from the
> below comment as well.
> 
> /*
> * Propagate the change to children.  For SET NO INHERIT, we don't
> * recursively affect children, just the immediate level.
> */
> 
> This is the comment from ATExecAlterConstrInheritability().

Ah right.  Fixed that and pushed.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/



pgsql-hackers by date:

Previous
From: Dmitrii Bondar
Date:
Subject: Re: [fixed] Trigger test
Next
From: John Naylor
Date:
Subject: Re: [PATCH] SVE popcount support