Re: BUG #18746: /src/backend/parser/parse_utilcmd.c - Mailing list pgsql-bugs

From Alvaro Herrera
Subject Re: BUG #18746: /src/backend/parser/parse_utilcmd.c
Date
Msg-id 202412091433.cg4ae6bd7fjr@alvherre.pgsql
Whole thread Raw
In response to BUG #18746: /src/backend/parser/parse_utilcmd.c  (PG Bug reporting form <noreply@postgresql.org>)
List pgsql-bugs
On 2024-Dec-09, PG Bug reporting form wrote:

> Dynamic memory, referenced by 'colname', is allocated at ruleutils.c:3587 by
> calling function 'deparse_expression' at parse_utilcmd.c:4061 and lost at
> parse_utilcmd.c:4100.

I think this refers to transformPartitionBound() which calls
deparse_expression().  I don't think a memory leak here is very
interesting, because this is DDL code which should be called in a
short-lived memory context, so it's freed soon afterwards.  (I bet you
could find thousands of cases of similar situations elsewhere in the DDL
code.)

Indeed, transformPartitionBound is only called by DefineRelation (used
to create a table or similar) or transformPartitionCmd, which is called
for ALTER TABLE ... ATTACH/DETACH PARTITION.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"The problem with the future is that it keeps turning into the present"
(Hobbes)



pgsql-bugs by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: [BUGS] BUG #10123: Weird entries in pg_stat_activity
Next
From: Tom Lane
Date:
Subject: Re: BUG #18742: /src/backend/rewrite/rewriteHandler.c