Re: Fix array access (src/bin/pg_dump/pg_dump.c) - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Fix array access (src/bin/pg_dump/pg_dump.c)
Date
Msg-id 202411121911.3vwdrzfgjt4o@alvherre.pgsql
Whole thread Raw
Responses Re: Fix array access (src/bin/pg_dump/pg_dump.c)
List pgsql-hackers
On 2024-Nov-12, Ranier Vilela wrote:

> Per Coverity.
> 
> The function *determineNotNullFlags* has a little oversight.
> The struct field *notnull_islocal* is an array.
> 
> I think this is a simple typo.
> Fix using array notation access.

Yeah, thanks, I had been made aware of this bug.  Before fixing I'd like
to construct a test case that tickles that code, because it's currently
uncovered  *shudder*

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Find a bug in a program, and fix it, and the program will work today.
Show the program how to find and fix a bug, and the program
will work forever" (Oliver Silfridge)



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Commit Timestamp and LSN Inversion issue
Next
From: Masahiko Sawada
Date:
Subject: Re: logical replication: restart_lsn can go backwards (and more), seems broken since 9.4