Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN - Mailing list pgsql-hackers

From Tatsuo Ishii
Subject Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN
Date
Msg-id 20240919.090134.1961749747398456709.ishii@postgresql.org
Whole thread Raw
In response to Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
> On Thu, 19 Sept 2024 at 00:13, Tatsuo Ishii <ishii@postgresql.org> wrote:
>> Actually there's one more executor node type that uses tuplestore:
>> recursive union (used in "with recursive"). The particular node type
>> uses two tuplestore and we cannot simply apply tuplestore_get_stats()
>> to the node type. We need to modify RecursiveUnionState to track the
>> maximum tuplestore usage. I am not sure this would be worth the
>> effort. Opinion?
> 
> Could you add the two sizes together and take the storage type from
> the tuplestore with the highest storage size?

I don't think this works because tuplestore_begin/tuplestore_end are
called while executing the node (ExecRecursiveUnion).

I think the way you are proposing only shows the stats last time when
those tuplestore are created.

Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp



pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: Using per-transaction memory contexts for storing decoded tuples
Next
From: Andy Fan
Date:
Subject: Re: detoast datum into the given buffer as a optimization.