Re: Use read streams in pg_visibility - Mailing list pgsql-hackers

From Noah Misch
Subject Re: Use read streams in pg_visibility
Date
Msg-id 20240905155435.74.nmisch@google.com
Whole thread Raw
In response to Re: Use read streams in pg_visibility  (Nazir Bilal Yavuz <byavuz81@gmail.com>)
List pgsql-hackers
On Thu, Sep 05, 2024 at 03:59:53PM +0300, Nazir Bilal Yavuz wrote:
> On Wed, 4 Sept 2024 at 21:43, Noah Misch <noah@leadboat.com> wrote:
> > https://postgr.es/m/CAEudQAozv3wTY5TV2t29JcwPydbmKbiWQkZD42S2OgzdixPMDQ@mail.gmail.com
> > then observed that collect_corrupt_items() was now guaranteed to never detect
> > corruption.  I have pushed revert ddfc556 of the pg_visibility.c changes.  For
> > the next try, could you add that testing we discussed?
> 
> Do you think that corrupting the visibility map and then seeing if
> pg_check_visible() and pg_check_frozen() report something is enough?

I think so.  Please check that it would have caught both the blkno bug and the
above bug.



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: json_query conditional wrapper bug
Next
From: Maxim Orlov
Date:
Subject: Re: Test 041_checkpoint_at_promote.pl faild in installcheck due to missing injection_points