On Sun, Jun 30, 2024 at 05:01:52PM -0400, Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
> > On Sun, Jun 30, 2024 at 02:58:00PM -0400, Tom Lane wrote:
> >> So b3f5ccebd promptly blew up on fairywren [1]:
>
> > It does look consistent with IPC::Run predating v20220807.0, hence lacking the
> > https://github.com/toddr/IPC-Run/issues/142 fix. I wondered how this animal
> > was passing 002_pg_upgrade.pl, but it seems the animal has run TAP suites only
> > occasionally. Passes in the last week were TAP-free.
>
> Hmm, drongo just failed in the same way. (It seems to likewise
> run TAP tests only some of the time, which I don't understand
> because the $Script_Config output looks the same between runs
> with TAP tests and runs without.)
On further reflection, 002_pg_upgrade.pl may not fail with old IPC::Run. It
may just create a database with an unintended name, losing some test coverage.
> I'm tempted to lobotomize the new test case on Windows until
> we have that resolved.
Sounds fine. The pg_upgrade suite adequately tests appendShellString() and
appendConnStrVal() with the larger character repertoire, so it's enough for
pg_createsubscriber to test just a space or so.
