Re: Is there an undocumented Syntax Check in Meson? - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Is there an undocumented Syntax Check in Meson?
Date
Msg-id 20240509193630.zpza5mjd7dkmsgm4@awork3.anarazel.de
Whole thread Raw
In response to Re: Is there an undocumented Syntax Check in Meson?  (Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>)
Responses Re: Is there an undocumented Syntax Check in Meson?
List pgsql-hackers
Hi,

On 2024-05-09 20:12:38 +0100, Dagfinn Ilmari Mannsåker wrote:
> Attached is a patch which adds a check-docs target for meson, which
> takes 0.3s on my laptop.

Nice.


> +checkdocs = custom_target('check-docs',
> +  input: 'postgres.sgml',
> +  output: 'check-docs',
> +  depfile: 'postgres-full.xml.d',
> +  command: [xmllint,  '--nonet', '--valid', '--noout',
> +            '--path', '@OUTDIR@', '@INPUT@'],
> +  depends: doc_generated,
> +  build_by_default: false,
> +)
> +alias_target('check-docs', checkdocs)

Isn't the custom target redundant with postgres_full_xml? I.e. you could just
have the alias_target depend on postgres_full_xml?

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: add --no-sync to pg_upgrade's calls to pg_dump and pg_dumpall
Next
From: Dagfinn Ilmari Mannsåker
Date:
Subject: Re: open items