Re: pg_dumpall with flag --no-role-passwords omits roles comments as well - Mailing list pgsql-general

From Alvaro Herrera
Subject Re: pg_dumpall with flag --no-role-passwords omits roles comments as well
Date
Msg-id 202403211327.3mwhawgoeqp3@alvherre.pgsql
Whole thread Raw
In response to Re: pg_dumpall with flag --no-role-passwords omits roles comments as well  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: pg_dumpall with flag --no-role-passwords omits roles comments as well  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-general
On 2024-Mar-21, Daniel Gustafsson wrote:

> On 21 Mar 2024, at 13:28, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> 
> > I very much doubt that they realized that comments were going to be
> > omitted.  But clearly it's just a mistake, and easily fixed.
> 
> It sure looks like a search/replace kind of bug.  I had just typed up the exact
> same patch with the addition of a comment on why pg_authid is used and was
> about to hit send when your email came =) Are you committing it or do you want
> me to take care of it?

Hah :-)  Please do.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Here's a general engineering tip: if the non-fun part is too complex for you
to figure out, that might indicate the fun part is too ambitious." (John Naylor)
https://postgr.es/m/CAFBsxsG4OWHBbSDM%3DsSeXrQGOtkPiOEOuME4yD7Ce41NtaAD9g%40mail.gmail.com



pgsql-general by date:

Previous
From: Laurenz Albe
Date:
Subject: Re: Not able to purge partition
Next
From: gparc@free.fr
Date:
Subject: Re: Not able to purge partition