Re: common signal handler protection - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: common signal handler protection
Date
Msg-id 20240207171554.GA153000@nathanxps13
Whole thread Raw
In response to Re: common signal handler protection  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: common signal handler protection
List pgsql-hackers
Sorry for the noise.

On Wed, Feb 07, 2024 at 11:06:50AM -0600, Nathan Bossart wrote:
> I'd like to get this committed (to HEAD only) in the next few weeks.  TBH
> I'm not wild about the weird caveats (e.g., race conditions when pqsignal()
> is called within a signal handler), but I also think it is unlikely that
> they cause any issues in practice.  Please do let me know if you have any
> concerns about this.

Perhaps we should add a file global bool that is only set during
wrapper_handler().  Then we could Assert() or elog(ERROR, ...) if
pqsignal() is called with it set.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: "Euler Taveira"
Date:
Subject: Re: Possibility to disable `ALTER SYSTEM`
Next
From: John Morris
Date:
Subject: Re: Where can I find the doxyfile?