Re: Draft release notes for minor releases are up - Mailing list pgsql-hackers

On Fri, Feb 02, 2024 at 12:54:48PM -0500, Tom Lane wrote:
> First-draft release notes for 16.2 are available at
> 
> https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=87dcc5e45fad3021514f01360d3a2abd4e6480ee

> +    <listitem>
> +<!--
> +Author: Heikki Linnakangas <heikki.linnakangas@iki.fi>
> +Branch: master [6a1ea02c4] 2024-01-29 13:46:22 +0200
> +Branch: REL_16_STABLE [b899e00e7] 2024-01-29 13:46:30 +0200
> +Branch: REL_15_STABLE [e43425f48] 2024-01-29 13:46:42 +0200
> +Branch: REL_14_STABLE [f120c0872] 2024-01-29 13:46:43 +0200
> +Branch: REL_13_STABLE [e74c91665] 2024-01-29 13:46:45 +0200
> +Branch: REL_12_STABLE [e6511fe64] 2024-01-29 13:46:48 +0200
> +-->
> +     <para>
> +      Fix insufficient locking when cleaning up an incomplete split of
> +      a GIN index's internal page (Fei Changhong, Heikki Linnakangas)
> +     </para>
> +
> +     <para>
> +      The code tried to do this with shared rather than exclusive lock on
> +      the buffer.  This could lead to index corruption if two processes
> +      attempted the cleanup concurrently.
> +     </para>
> +    </listitem>

Shall the top of the notes advise to reindex GIN indexes?

> +    <listitem>
> +<!--
> +Author: Noah Misch <noah@leadboat.com>
> +Branch: master [df220714e] 2024-02-01 13:44:19 -0800
> +Branch: REL_16_STABLE [6d423e9ff] 2024-02-01 13:44:22 -0800
> +Branch: REL_15_STABLE [d493bed28] 2024-02-01 13:44:22 -0800
> +Branch: master [0b6517a3b] 2024-02-01 13:44:19 -0800
> +Branch: REL_16_STABLE [48a6bf5c4] 2024-02-01 13:44:22 -0800
> +Branch: REL_15_STABLE [8fa4a1ac6] 2024-02-01 13:44:23 -0800
> +-->
> +     <para>
> +      Add more interlocks between <command>CREATE DATABASE</command> and
> +      base backup (Noah Misch)
> +     </para>
> +
> +     <para>
> +      This fixes some cases where a base backup taken concurrently
> +      with <command>CREATE DATABASE</command> could produce a corrupt
> +      image of the new database.
> +     </para>
> +    </listitem>

Things I'd like to capture for this one:

- Commit 0b6517a3b deals with crash recovery, not base backups.
- Connection establishment will fail if one of these bugs corrupted the
  database, so there's no need to worry about silent corruption.  (My commit
  messages didn't make that clear.)

Perhaps like this:

diff --git a/doc/src/sgml/release-16.sgml b/doc/src/sgml/release-16.sgml
index 21387e3..8997279 100644
--- a/doc/src/sgml/release-16.sgml
+++ b/doc/src/sgml/release-16.sgml
@@ -750,15 +750,15 @@ Branch: REL_16_STABLE [48a6bf5c4] 2024-02-01 13:44:22 -0800
 Branch: REL_15_STABLE [8fa4a1ac6] 2024-02-01 13:44:23 -0800
 -->
      <para>
-      Add more interlocks between <command>CREATE DATABASE</command> and
-      base backup (Noah Misch)
+      Fix durability of <command>CREATE DATABASE</command> (Noah Misch)
      </para>
 
      <para>
-      This fixes some cases where a base backup taken concurrently
-      with <command>CREATE DATABASE</command> could produce a corrupt
-      image of the new database.
+      Recovery failed, or establishing connections to the new database failed.
+      Effects required an operating system crash or base backup, concurrently
+      with or shortly after the <command>CREATE DATABASE</command>.
      </para>
+
     </listitem>
 
     <listitem>