Re: core dumps in auto_prewarm, tests succeed - Mailing list pgsql-hackers

Hi,

On 2024-01-22 15:19:36 -0600, Nathan Bossart wrote:
> On Mon, Jan 22, 2024 at 02:44:57PM -0600, Nathan Bossart wrote:
> > On Mon, Jan 22, 2024 at 12:41:17PM -0800, Andres Freund wrote:
> >> I noticed that I was getting core dumps while executing the tests, without the
> >> tests failing. Backtraces are vriations of this:
> > 
> > Looking, thanks for the heads-up.
> 
> I think this is because the autoprewarm state was moved to a DSM segment,
> and DSM segments are detached before the on_shmem_exit callbacks are called
> during process exit.  Moving apw_detach_shmem to the before_shmem_exit list
> seems to resolve the crashes.

That seems plausible. Would still be nice to have at least this test ensure
that the shutdown code works. Perhaps just a check of the control file after
shutdown, ensuring that the state is "shutdowned" vs crashed?

Greetings,

Andres Freund