Re: Report planning memory in EXPLAIN ANALYZE - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Report planning memory in EXPLAIN ANALYZE
Date
Msg-id 202401181112.gijhiq6dwfyd@alvherre.pgsql
Whole thread Raw
In response to Re: Report planning memory in EXPLAIN ANALYZE  (Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>)
Responses Re: Report planning memory in EXPLAIN ANALYZE
List pgsql-hackers
On 2024-Jan-18, Ashutosh Bapat wrote:

Hmm ... TBH I don't like the "showed_planning" thing very much, but if
we need to conditionalize the printing of "Planning:" on whether we
print either of buffers or memory, maybe there's no way around something
like what you propose.

However, I don't understand this output change, and I think it indicates
a bug in the logic there:

> diff --git a/src/test/regress/expected/explain.out b/src/test/regress/expected/explain.out
> index 86bfdfd29e..55694505a7 100644
> --- a/src/test/regress/expected/explain.out
> +++ b/src/test/regress/expected/explain.out
> @@ -331,15 +331,15 @@ select explain_filter('explain (memory) select * from int8_tbl i8');
>                       explain_filter                      
>  ---------------------------------------------------------
>   Seq Scan on int8_tbl i8  (cost=N.N..N.N rows=N width=N)
> - Planner Memory: used=N bytes allocated=N bytes
> +   Memory: used=N bytes, allocated=N bytes
>  (2 rows)

Does this really make sense?

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"Linux transformó mi computadora, de una `máquina para hacer cosas',
en un aparato realmente entretenido, sobre el cual cada día aprendo
algo nuevo" (Jaime Salinas)



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: minor replication slot docs edits
Next
From: Bharath Rupireddy
Date:
Subject: Re: Reduce useless changes before reassembly during logical replication