Re: introduce dynamic shared memory registry - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: introduce dynamic shared memory registry
Date
Msg-id 20240106163516.GB2435448@nathanxps13
Whole thread Raw
In response to Re: introduce dynamic shared memory registry  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: introduce dynamic shared memory registry
List pgsql-hackers
On Sat, Jan 06, 2024 at 07:34:15PM +0530, Bharath Rupireddy wrote:
> 1. Update all the copyright to the new year. A run of
> src/tools/copyright.pl on the source tree will take care of it at some
> point, but still it's good if we can update while we are here.

Done.

> 2. Typo: missing "an" before "already-attached".
> +        /* Return address of already-attached DSM registry entry. */

Done.

> 3. Use NAMEDATALEN instead of 64?
> +    char        key[64];

I kept this the same, as I didn't see any need to tie the key size to
NAMEDATALEN.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Attachment

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Emit fewer vacuum records by reaping removable tuples during pruning
Next
From: Zhang Mingli
Date:
Subject: Re: weird GROUPING SETS and ORDER BY behaviour