Hi,
On 2023-12-01 15:55:29 -0600, Tristan Partin wrote:
> Commits look fine to me, but I hate the new target names...
You shouldn't ever need to use them anywhere - that's what the alias is for...
Happy to go another route if you have a suggestion.
> > + for name, v in targets_info_byname.items():
> > + if len(targets_info_byname[name]) > 1:
>
> My only comment is that you could reverse the logic and save yourself an
> indentation.
>
> - if len(targets_info_byname[name]) > 1:
> + if len(targets_info_byname[name]) <= 1:
> + continue
>
> But whatever you want.
Makes sense.