retire MemoryContextResetAndDeleteChildren backwards compatibility macro - Mailing list pgsql-hackers

From Nathan Bossart
Subject retire MemoryContextResetAndDeleteChildren backwards compatibility macro
Date
Msg-id 20231113185950.GA1668018@nathanxps13
Whole thread Raw
Responses Re: retire MemoryContextResetAndDeleteChildren backwards compatibility macro
Re: retire MemoryContextResetAndDeleteChildren backwards compatibility macro
List pgsql-hackers
I just found myself researching the difference between MemoryContextReset()
and MemoryContextResetAndDeleteChildren(), and it turns out that as of
commit eaa5808 (2015), there is none.
MemoryContextResetAndDeleteChildren() is just a backwards compatibility
macro for MemoryContextReset().  I found this surprising because it sounds
like they do very different things.

Shall we retire this backwards compatibility macro at this point?  A search
of https://codesearch.debian.net/ does reveal a few external uses, so we
could alternatively leave it around and just update Postgres to stop using
it, but I don't think it would be too burdensome for extension authors to
fix if we removed it completely.

Patch attached.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Cleaning up array_in()
Next
From: Bruce Momjian
Date:
Subject: Re: Question about non-blocking mode in libpq