Re: should frontend tools use syncfs() ? - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: should frontend tools use syncfs() ?
Date
Msg-id 20230920190748.GA2960472@nathanxps13
Whole thread Raw
In response to Re: should frontend tools use syncfs() ?  (Maxim Orlov <orlovmg@gmail.com>)
Responses Re: should frontend tools use syncfs() ?
List pgsql-hackers
On Wed, Sep 20, 2023 at 03:12:56PM +0300, Maxim Orlov wrote:
> As a solution, I suggest renaming sync_method in xlog module to
> wal_sync_method. In fact,
> appropriate GUC for this variable, called "wal_sync_method" and I see no
> reason not to use
> the exact same name for a variable in xlog module.

+1

I think we should also consider renaming things like SYNC_METHOD_FSYNC to
WAL_SYNC_METHOD_FSYNC, and sync_method_options to wal_sync_method_options.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: "Tristan Partin"
Date:
Subject: Re: pg_upgrade --check fails to warn about abstime
Next
From: Andrew Dunstan
Date:
Subject: Re: remaining sql/json patches