Re: Strange presentaion related to inheritance in \d+ - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Strange presentaion related to inheritance in \d+
Date
Msg-id 20230829172828.5qi2pfbladvfgvsg@alvherre.pgsql
Whole thread Raw
In response to Re: Strange presentaion related to inheritance in \d+  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: Strange presentaion related to inheritance in \d+
List pgsql-hackers
On 2023-Aug-29, Kyotaro Horiguchi wrote:

> Attached is the initial version of the patch. It prevents "CREATE
> TABLE" from executing if there is an inconsisntent not-null
> constraint.  Also I noticed that "ALTER TABLE t ADD NOT NULL c NO
> INHERIT" silently ignores the "NO INHERIT" part and fixed it.

Great, thank you.  I pushed it after modifying it a bit -- instead of
throwing the error in MergeAttributes, I did it in
AddRelationNotNullConstraints().  It seems cleaner this way, mostly
because we already have to match these two constraints there.  (I guess
you could argue that we waste catalog-insertion work before the error is
reported and the whole thing is aborted; but I don't think this is a
serious problem in practice.)

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"En las profundidades de nuestro inconsciente hay una obsesiva necesidad
de un universo lógico y coherente. Pero el universo real se halla siempre
un paso más allá de la lógica" (Irulan)



pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: broken master regress tests
Next
From: Nathan Bossart
Date:
Subject: Re: tablecmds.c/MergeAttributes() cleanup