Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Add function to_oct - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: [PATCH] Add function to_oct
Date
Msg-id 20230823145430.GA1014432@nathanxps13
Whole thread Raw
In response to Re: [PATCH] Add function to_oct  (Peter Eisentraut <peter@eisentraut.org>)
List pgsql-hackers
Tree view 
On Tue, Aug 22, 2023 at 04:57:02PM +0200, Peter Eisentraut wrote:
> On 22.08.23 16:26, Nathan Bossart wrote:
>> > I don't understand the reason for this handling of negative values.  I would
>> > expect that, say, to_hex(-1234) would return '-' || to_hex(1234).
>> For this patch set, I was trying to retain the current behavior, which is
>> to return the two's complement representation.  I'm open to changing this
>> if there's agreement on what the output should be.
> 
> Ah, if there is existing behavior then we should probably keep it.

Committed.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: using SysCacheGetAttrNotNull in place of heap_getattr
Next
From: Yugo NAGATA
Date:
Subject: Re: pgbench: allow to exit immediately when any client is aborted