Re: Make all Perl warnings fatal - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Make all Perl warnings fatal
Date
Msg-id 20230822132028.jea3gfvs5lhrcjcb@alvherre.pgsql
Whole thread Raw
In response to Make all Perl warnings fatal  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: Make all Perl warnings fatal
Re: Make all Perl warnings fatal
List pgsql-hackers
On 2023-Aug-10, Peter Eisentraut wrote:

> I wanted to figure put if we can catch these more reliably, in the style of
> -Werror.  AFAICT, there is no way to automatically turn all warnings into
> fatal errors.  But there is a way to do it per script, by replacing
> 
>     use warnings;
> 
> by
> 
>     use warnings FATAL => 'all';
> 
> See attached patch to try it out.

BTW in case we do find that there's some unforeseen problem and we want
to roll back, it would be great to have a way to disable this without
having to edit every single Perl file again later.  However, I didn't
find a way to do it -- I thought about creating a separate PgWarnings.pm
file that would do the "use warnings FATAL => 'all'" dance and which
every other Perl file would use or include; but couldn't make it work.
Maybe some Perl expert knows a good answer to this.

Maybe the BEGIN block of each file can `eval` a new PgWarnings.pm that
emits the "use warnings" line?

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"No renuncies a nada. No te aferres a nada."



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Make all Perl warnings fatal
Next
From: Tom Lane
Date:
Subject: Re: list of acknowledgments for PG16