Re: Using defines for protocol characters - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Using defines for protocol characters
Date
Msg-id 20230816192956.GA2908487@nathanxps13
Whole thread Raw
In response to Re: Using defines for protocol characters  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: Using defines for protocol characters
List pgsql-hackers
On Tue, Aug 15, 2023 at 11:40:07PM +0200, Alvaro Herrera wrote:
> On 2023-Aug-16, Michael Paquier wrote:
> 
>> On Wed, Aug 16, 2023 at 06:25:09AM +0900, Tatsuo Ishii wrote:
>> > Currently pqcomm.h needs c.h which is not problem for Pgpool-II. But
>> > what about other middleware?
>> 
>> Why do you need to include directly c.h?  There are definitions in
>> there that are not intended to be exposed.
> 
> What this argument says is that these new defines should be in a
> separate file, not in pqcomm.h.  IMO that makes sense, precisely because
> these defines should be usable by third parties.

I moved the definitions out to a separate file in v6.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Attachment

pgsql-hackers by date:

Previous
From: Michail Nikolaev
Date:
Subject: Re: Replace known_assigned_xids_lck by memory barrier
Next
From: "Jonathan S. Katz"
Date:
Subject: PostgreSQL 16 RC1 + GA release dates