On Tue, Aug 15, 2023 at 11:40:07PM +0200, Alvaro Herrera wrote:
> On 2023-Aug-16, Michael Paquier wrote:
>
>> On Wed, Aug 16, 2023 at 06:25:09AM +0900, Tatsuo Ishii wrote:
>> > Currently pqcomm.h needs c.h which is not problem for Pgpool-II. But
>> > what about other middleware?
>>
>> Why do you need to include directly c.h? There are definitions in
>> there that are not intended to be exposed.
>
> What this argument says is that these new defines should be in a
> separate file, not in pqcomm.h. IMO that makes sense, precisely because
> these defines should be usable by third parties.
I moved the definitions out to a separate file in v6.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com