Hi,
On 2023-08-11 20:11:34 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > On 2023-08-11 18:30:02 -0400, Tom Lane wrote:
> >> +1 for including this in CI tests
>
> > I didn't even mean CI - I meant 'make check-world' / 'meson test'. Which of
> > course would include CI automatically.
>
> Hmm. I'm allergic to anything that significantly increases the cost
> of check-world, and this seems like it'd do that.
Hm, compared to the cost of check-world it's not that large, but still,
annoying to make it larger.
We can make it lot cheaper, but perhaps not in a general enough fashion that
it's suitable for a test.
pgindent already can query git (for --commit). We could teach pgindent to
ask git what remote branch is being tracked, and constructed a list of files
of the difference between the remote branch and the local branch?
That option could do something like:
git diff --name-only $(git rev-parse --abbrev-ref --symbolic-full-name @{upstream})
That's pretty quick, even for a relatively large delta.
> Maybe we could automate it, but not as part of check-world per se?
We should definitely do that. Another related thing that'd be useful to
script is updating typedefs.list with the additional typedefs found
locally. Right now the script for that still lives in the
Greetings,
Andres Freund
