Re: Fix last unitialized memory warning - Mailing list pgsql-hackers

From Julien Rouhaud
Subject Re: Fix last unitialized memory warning
Date
Msg-id 20230810005643.kw4jgrvueq6dfn64@jrouhaud
Whole thread Raw
In response to Re: Fix last unitialized memory warning  ("Tristan Partin" <tristan@neon.tech>)
Responses Re: Fix last unitialized memory warning
List pgsql-hackers
On Wed, Aug 09, 2023 at 10:29:56AM -0500, Tristan Partin wrote:
> On Wed Aug 9, 2023 at 10:02 AM CDT, Peter Eisentraut wrote:
> >
> > This patch has apparently upset one buildfarm member with a very old
> > compiler:
> > https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=lapwing&br=HEAD
> >
> > Any thoughts?
>
> Best I could find is SO question[0] which links out to[1]. Try this patch.
> Otherwise, a memset() would probably do too.

Yes, it's a buggy warning that came up in the past a few times as I recall, for
which we previously used the {{...}} approach to silence it.

As there have been previous complaints about it, I removed the -Werror from
lapwing and forced a new run to make it green again.



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: PG 16 draft release notes ready
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: Incorrect handling of OOM in WAL replay leading to data loss