Re: "duplicated" wait events - Mailing list pgsql-hackers

From Kyotaro Horiguchi
Subject Re: "duplicated" wait events
Date
Msg-id 20230807.144634.593425755953926995.horikyota.ntt@gmail.com
Whole thread Raw
In response to "duplicated" wait events  ("Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>)
Responses Re: "duplicated" wait events
List pgsql-hackers
At Fri, 4 Aug 2023 17:07:51 +0200, "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com> wrote in 
> SynRep currently appears in "IPC" and "LWLock" (see [2])
> WALWrite currently appears in "IO" and "LWLock" (see [2])
> 
> I think that can lead to confusion and it would be better to avoid
> duplicate wait event
> name across Wait Class (and so fix those 2 ones above), what do you
> think?

I think it would be handy to be able to summirize wait events by event
names, instead of classes. In other words, grouping wait events
through all classes according to their purpose. From that perspective,
I'm rather fan of consolidating event names (that is, the opposite of
your proposal).

However, it seems the event weren't named with this consideration. So
I'm on the fence about this change.


By the way, I couldn't figure out how to tag event names without
messing up the source tree. This causes meson to refuse a build..

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center



pgsql-hackers by date:

Previous
From: jian he
Date:
Subject: Re: Cleaning up array_in()
Next
From: Julien Rouhaud
Date:
Subject: Re: [PoC] pg_upgrade: allow to upgrade publisher node