Re: add timing information to pg_upgrade - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: add timing information to pg_upgrade
Date
Msg-id 20230728184735.GC3661419@nathanxps13
Whole thread Raw
In response to Re: add timing information to pg_upgrade  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: add timing information to pg_upgrade
List pgsql-hackers
On Fri, Jul 28, 2023 at 10:38:14AM -0700, Nathan Bossart wrote:
> I'm okay with simply adding the time.  However, I wonder if we want to
> switch to seconds, minutes, hours, etc. if the step takes longer.  This
> would add a bit of complexity, but it would improve human readability.
> Alternatively, we could keep the code simple and machine readable by always
> using milliseconds.

... or maybe we show both like psql does.  Attached іs a new version of the
patch in which I've made use of the INSTR_TIME_* macros and enhanced the
output formatting (largely borrowed from PrintTiming() in
src/bin/psql/common.c).

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Attachment

pgsql-hackers by date:

Previous
From: Farias de Oliveira
Date:
Subject: Re: In Postgres 16 BETA, should the ParseNamespaceItem have the same index as it's RangeTableEntry?
Next
From: Peter Geoghegan
Date:
Subject: Re: Eager page freeze criteria clarification