Re: harmonize password reuse in vacuumdb, clusterdb, and reindexdb - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: harmonize password reuse in vacuumdb, clusterdb, and reindexdb
Date
Msg-id 20230728171429.GA3764457@nathanxps13
Whole thread Raw
In response to Re: harmonize password reuse in vacuumdb, clusterdb, and reindexdb  (Nathan Bossart <nathandbossart@gmail.com>)
List pgsql-hackers
On Wed, Jul 19, 2023 at 10:43:11AM -0700, Nathan Bossart wrote:
> On Wed, Jun 28, 2023 at 10:24:09PM -0700, Nathan Bossart wrote:
>> The same commit that added this comment (ff402ae) also set the
>> allow_password_reuse parameter to true in vacuumdb's connectDatabase()
>> calls.  I found a message from the corresponding thread that provides some
>> additional detail [0].  I wonder if this comment should instead recommend
>> against using the allow_password_reuse flag unless reconnecting to the same
>> host/port/user target.  Connecting to different databases with the same
>> host/port/user information seems okay.  Maybe I am missing something... 
> 
> I added Tom here since it looks like he was the original author of this
> comment.  Tom, do you have any concerns with updating the comment for
> connectDatabase() in src/fe_utils/connect_utils.c like this?

I went ahead and committed this.  I'm happy to revisit if there are
concerns.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Christoph Berg
Date:
Subject: New PostgreSQL Contributors
Next
From: Vik Fearing
Date:
Subject: Re: New PostgreSQL Contributors